PDA

View Full Version : awstat icons should be symbolik link



ehsanch
04-16-2010, 01:51 PM
i found that in every user hosting account , there is an awstats/icon folder with 2mb size , and some static files.
this folder shuld be a symbolic link , for resource it use on disk space , and backup/restore time.

ranz
04-17-2010, 06:02 AM
I wonder how many other apps have similar scenarios ...

BTW, awstats is not what everyone uses (although I like it).

floyd
04-17-2010, 01:35 PM
BTW, awstats is not what everyone uses (although I like it).

How do you know what ehsanch's accounts use? Maybe all of his hosting account do use awstats. That is up to him to decide what his users use.

DirectAdmin Support
04-17-2010, 02:29 PM
Hello,

I've changed the awstats_process.sh.

I've modified this line:
cp -Rp ${AWSTATS}/wwwroot/icon ${STATS_DIR}and changed it to
#April 17, changed to link, below
#cp -Rp ${AWSTATS}/wwwroot/icon ${STATS_DIR}I've then added this code, just below the "fi", after the code we just commented out:
ICON=${STATS_DIR}/icon
if [ ! -h $ICON ]; then
rm -rf $ICON
ln -sf ${AWSTATS}/wwwroot/icon $ICON
fiThis should remove the icon directory and replace it with a link for existing awstats/icon paths, and for new accounts as well.

John

ehsanch
04-17-2010, 11:03 PM
Thank u for your quick resolve :)

ranz
04-18-2010, 06:50 AM
How do you know what ehsanch's accounts use? Maybe all of his hosting account do use awstats. That is up to him to decide what his users use.

I wasn't referring to ehsanch's clients. I was referring to all DirectAdmin users. Are you always like this? :rolleyes:

floyd
04-18-2010, 10:38 AM
Are you always like this? :rolleyes:

I have been a contributor here for 5 years. Feel free to go back and look. If you want accurate answers there are several that have been here a long time that you can look to. If you want to feel loved .....

Arieh
07-28-2010, 07:41 AM
Little bump, I think this possible broke my icons.

When I visit my awastats page through directadmin, the icons aren't visible. When I click on it -> view image it says Error: document not found.

When I visit it through domain.tld/stats they however do work.

Can't the CMD_FILE_MANAGER handle symlinks maybe?

ditto
07-28-2010, 08:28 AM
Little bump, I think this possible broke my icons[..]

It is like that for everybody, it is a bug introduced in version 1.36. Here is more information: http://www.directadmin.com/features.php?id=1098

Arieh
07-28-2010, 09:03 AM
Thanks. Is there are list of these known bugs?

ditto
07-28-2010, 09:06 AM
I don't think so. I only know about this one because it was me who reported the bug to DirectAdmin on email, and they added it to the version system and sent me the link.

ditto
07-28-2010, 09:10 AM
Here is another AWStats bug that I have been waiting for a fix for, for a long time. How much longer will we have to wait for this one to be fixed?

awstats doesn't compute last day of month: http://www.directadmin.com/features.php?id=974

DirectAdmin Support
07-28-2010, 12:33 PM
ditto: I just took a look at it, and implemented the fix. The code is in the versions entry, so can be added to your awstats_process.sh now if you'd like.

For the icons issue, there is a workaround if you want to go back to the old way, but I'll be adding a new CMD_AWSTATS function for the next release, so it can see the icons by following the link.

John

ditto
07-28-2010, 12:39 PM
ditto: I just took a look at it, and implemented the fix. The code is in the versions entry, so can be added to your awstats_process.sh now if you'd like.

Thank you so much! I am sorry that I was being a little negative about this, but it was a problem for me and my customers. Wonderful!

About the icons issue, I think I will wait for the next release, as I don't consider that as a big problem that need to be fixed right away.

Again, thank you! I am actual very pleased with DirectAdmin, and so are my customers! :)